Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Zero stock fix #8766

Merged
merged 2 commits into from
Dec 25, 2024
Merged

Conversation

SchrodingersGat
Copy link
Member

- Allow stock adjustments with zero quantity
@SchrodingersGat SchrodingersGat added stock Related to Stock models backport Apply this label to a PR to enable auto-backport action Platform UI Related to the React based User Interface backport-to-0.17.x Backport these changes to the 0.17.x branch labels Dec 25, 2024
@SchrodingersGat SchrodingersGat added this to the 1.0.0 milestone Dec 25, 2024
Copy link

netlify bot commented Dec 25, 2024

Deploy Preview for inventree-web-pui-preview ready!

Name Link
🔨 Latest commit cebe53e
🔍 Latest deploy log https://app.netlify.com/sites/inventree-web-pui-preview/deploys/676c9225dc6e9d0008f46ad5
😎 Deploy Preview https://deploy-preview-8766--inventree-web-pui-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 100 (no change from production)
Accessibility: 86 (no change from production)
Best Practices: 100 (no change from production)
SEO: 78 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Dec 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.26%. Comparing base (c79fc28) to head (cebe53e).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8766      +/-   ##
==========================================
+ Coverage   85.20%   85.26%   +0.06%     
==========================================
  Files        1172     1172              
  Lines       51538    51541       +3     
  Branches     2089     2090       +1     
==========================================
+ Hits        43911    43946      +35     
+ Misses       7118     7075      -43     
- Partials      509      520      +11     
Flag Coverage Δ
backend 86.97% <100.00%> (+<0.01%) ⬆️
pui 69.22% <100.00%> (+0.31%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@SchrodingersGat SchrodingersGat merged commit ae7f4e3 into inventree:master Dec 25, 2024
31 checks passed
@SchrodingersGat SchrodingersGat deleted the zero-stock-fix branch December 25, 2024 23:42
github-actions bot pushed a commit that referenced this pull request Dec 25, 2024
* Change backend validation

- Allow stock adjustments with zero quantity

* Frontend changes

(cherry picked from commit ae7f4e3)
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
0.17.x

Questions ?

Please refer to the Backport tool documentation and see the Github Action logs for details

SchrodingersGat added a commit that referenced this pull request Dec 26, 2024
* Change backend validation

- Allow stock adjustments with zero quantity

* Frontend changes

(cherry picked from commit ae7f4e3)

Co-authored-by: Oliver <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport Apply this label to a PR to enable auto-backport action backport-to-0.17.x Backport these changes to the 0.17.x branch Platform UI Related to the React based User Interface stock Related to Stock models
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot add stock once quantity reaches zero
1 participant